Raghav/weakest precondition#41
Merged
Merged
Conversation
added 30 commits
May 26, 2026 17:14
…eted func/sort decls yet
…ke this a flag and don't mod array selects
iangneal
requested changes
Jul 6, 2026
added 16 commits
July 6, 2026 20:26
iangneal
requested changes
Jul 9, 2026
iangneal
left a comment
iangneal
left a comment
Collaborator
There was a problem hiding this comment.
Just a few nits, otherwise LGTM
| /// Default z3 + cvc5 portfolio | ||
| llvm::SmallVector<SolverInvocationSpec> getWeakestPreconditionPortfolio(); | ||
|
|
||
| /// Convenient utilities |
Collaborator
There was a problem hiding this comment.
The doxygen comment will only attach to the nearest function when documentation is auto-generated, so each function needs its own comment. Also this comment is not particularly useful, so you can just remove it since it's pretty straightforward. The checkUnsatWithPortfolio, however, is not obvious to me at first glance.
Comment on lines
+41
to
+42
| if (!call || !(call.calleeIsCompute() || call.calleeIsConstrain() || | ||
| call.calleeIsProduct())) { |
Collaborator
There was a problem hiding this comment.
Actually these should be call.calleeIsStruct*, because these versions only check the name, not if they're within a struct.
| << getOrCreate<ScalarLattice>(subcmp); | ||
| llvm::dbgs() << "In call: " << call << '\n'; | ||
| llvm::dbgs().indent(4) | ||
| << "Subcomponent symbol is: " << getOrCreate<ScalarLattice>(subcmp); |
Collaborator
There was a problem hiding this comment.
These debug prints should be wrapped in LLVM_DEBUG I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.